search

jazminschroeder / fedex

Ruby library to interact with FedEx Rate Web Service
105 stars 179 forks source link

add printed_label_origin option to shipment request #105

Closed axlekb closed 8 years ago

axlekb commented 8 years ago

I'd prefer to have a test for this, but the :customer_specified_detail option isn't tested either and there's no confirmation in the response of the server receiving that element other than then the label.

Seems like we need some request specs to make sure the build_xml is sending the correct XML, but that'll take some more time.

axlekb commented 8 years ago

I should add that I manually tested this and the address did correctly show up on the label.

axlekb commented 8 years ago

Anyone monitoring this anymore?

axlekb commented 8 years ago

So what's the deal here @jazminschroeder, I see other PRs merged, but no comments here!

jazminschroeder commented 8 years ago

Hi @axlekb! I am so sorry. Work keeps me very busy and I have not been able to take time to refactor and add more tests.. I am not sure how I missed your PR but it seems like the functionality you were proposing is already in master? Please take a look and let me know what you think. https://github.com/jazminschroeder/fedex/blob/master/lib/fedex/request/shipment.rb#L80

Thanks for your PR and for checking out the gem. I need to be more active or find active collaborators that can help me maintain it.