search

jazwa / rackstack

A modular 3d-printable mini rack system.
MIT License
523 stars 17 forks source link

[Feature Request] Windows rbuild.py #3

Closed miketweaver closed 1 year ago

miketweaver commented 1 year ago

I'm not sure why the instructions don't have windows support.

I was able to build just fine on windows:

PS C:\Users\User\Downloads\rackstack-1.1.1> python3.exe '.\rbuild.py' -b all -c micro
Building: eval_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack eval_P.scad
Building: hingeModule.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack hingeModule.scad
Building: magnetModuleLeft_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack magnetModuleLeft_P.scad
Building: magnetModuleRight_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack magnetModuleRight_P.scad
Building: mainRail_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack mainRail_P.scad
Building: rackFeet_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack rackFeet_P.scad
Building: rackJoiner_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack rackJoiner_P.scad
Building: sideWallLeft_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack sideWallLeft_P.scad
Building: sideWallRight_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack sideWallRight_P.scad
Building: stackConnectorBottom_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack stackConnectorBottom_P.scad
Building: xBar_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack xBar_P.scad
Building: xyPlate_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack xyPlate_P.scad
Building: yBar_P.scad from C:\Users\User\Downloads\rackstack-1.1.1\rack/print to C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack
C:\Users\User\Downloads\rackstack-1.1.1\rack/print C:\Users\User\Downloads\rackstack-1.1.1\stl\micro\rack yBar_P.scad

I had to add r to the beginning of the strings, but after that, it worked great.

# ------------- EDIT THESE VARIABLES WITH THE LOCATION OF YOUR OPENSCAD BINARIES
PATH_TO_OPENSCAD = r'C:\Users\User\scoop\apps\openscad\2021.01\openscad.exe'
PATH_TO_OPENSCAD_NIGHTLY = r'C:\Users\User\scoop\apps\openscad-dev\2023.09\openscad.exe'
jazwa commented 1 year ago

That's actually really good to know. I have no experience with windows development so I just called it unsupported. Let me just confirm this works on a windows box...

jazwa commented 1 year ago

Confirmed locally. I've changed the READMEs and added some extra comments in rbuild.py. Thank you for the suggestion!