search

jazzaj / home-assistant-homematic

Integrating homematic devices into Home-Assistant using pyhomematic
2 stars 2 forks source link

Moved event-callbacks + Thermostat-support added #3

Closed danielperna84 closed 8 years ago

danielperna84 commented 8 years ago

This PR adds support Thermostats (Homematic and MAX!), and all event-callbacks are now part of their platform-module to keep the component free of platform-specific code.

Since I don't have Switches / Dimmers and Lights, please make sure that my modifications don't limit the functionality.

jazzaj commented 8 years ago

Änderung sind integriert. Ich habe Lights und Switch noch etwas kürzen können (wird dich nicht interessieren) und bei Binary Sensor habe ich meine Fernbedienung wieder eingebaut (interessiert dich auch nicht).

Ansonsten Glückwunsch: Du bist in HA angekommen :-)

Vg Dirk

2016-05-05 23:13 GMT+02:00 Daniel notifications@github.com:

This PR adds support Thermostats (Homematic and MAX!), and all event-callbacks are now part of their platform-module to keep the component free of platform-specific code.

Since I don't have Switches / Dimmers and Lights, please make sure that my

modifications don't limit the functionality.

You can view, comment on, or merge this pull request online at:

https://github.com/jazzaj/home-assistant-homematic/pull/3 Commit Summary

  • Moved event-callback to platform. Testing needed.
  • Moved event-callback to platform. Testing needed.
  • Implemented Homematic and MAX! Thermostats
  • Removed event-callback code, added support for Thermostats
  • Moved event-callback to platform
  • Moved event-callback to platform

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/jazzaj/home-assistant-homematic/pull/3

danielperna84 commented 8 years ago

Oh, ich dachte die LONG_PRESS-Sachen wären vom Dimmer / Switch. Genau deshalb ist's sinnvoll den Code in die Platforms zu packen. :)