search

jazzband / dj-database-url

Use Database URLs in your Django Application.
https://pypi.org/project/dj-database-url/
BSD 3-Clause "New" or "Revised" License
1.49k stars 205 forks source link

Adding type hints #135

Closed sbdchd closed 1 year ago

sbdchd commented 4 years ago

I was wondering if you'd be open to adding type hints to the repo?

Otherwise, would it be okay if I added them to https://github.com/python/typeshed/

XF-FW commented 2 years ago

Hey @sbdchd . Since, you got no reply after 2 years, could you add the types you've setup on kodiak to the typeshed?

If you would prefer, I could do it as well, but since it's your code, I think you should do it. Just let me know!

Thank you!

sbdchd commented 2 years ago

@XF-FW feel free to do it!

mattseymour commented 2 years ago

I think with where python is no Adding type hints is a good shout. All the supported python version are now typehint compliant.

XF-FW commented 2 years ago

As of earlier today, you can now have typing support for this package, by installing the types-dj-database-url package.

palfrey commented 1 year ago

https://github.com/jazzband/dj-database-url/pull/198 adds in type hints (and mypy checks for them)

XF-FW commented 1 year ago

Could you let me know when this gets released, so I can deprecate the types-dj-database-url package from typeshed as per their policy[0] ?

[0] https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#third-party-library-removal-policy

palfrey commented 1 year ago

@mattseymour Can we do a new release with this in?

mattseymour commented 1 year ago

I will take into doing this shortly