search

jazzband / dj-database-url

Use Database URLs in your Django Application.
https://pypi.org/project/dj-database-url/
BSD 3-Clause "New" or "Revised" License
1.48k stars 205 forks source link

Add github workflows for checking contributing guidelines #163

Closed ParthS007 closed 2 years ago

ParthS007 commented 2 years ago

I would like to work on it.

jezdez commented 2 years ago

This has already partially been done via pre-commit and using pre-commit.ci. You may want to add a pylint pre-commit hook, if you'd like though.

jezdez commented 2 years ago

Here's how it looked for #162:

CleanShot 2022-05-25 at 12 41 54@2x

ParthS007 commented 2 years ago

okay, thanks. I will add for pylint check 👍

mattseymour commented 2 years ago

So I have no issue with pylint but we are running flake8 on the code base. But, will pylint really give us much more? Flake8 seems to be the goto tool for Jazzband projects. I worry it will be too strict and we will then start getting into configuration wars as each person has their own setup and way of doing things. Flake8 seems like a sensible compromise? What are your thoughts?

This is part of the reason flake8 was originally chosen as it seems to be a happy middle ground.

ParthS007 commented 2 years ago

I agree with having a minimal setup for configuration, I created the issue because it was mentioned here. We can go with having isort, black and flake8 only.

After running pylint, it shows some valid warnings which can be changed/improved without having the pre commit check as well and not to have strictness for config. I can work on them in a different PR and close this one?

mattseymour commented 2 years ago

I think thats probably a good shout for the time being. Becuase the project is so small I think trying to keep to a simple core set (as in other jazzband projects) seems sensible. But certainly do target the valid issues you have foud in pylint. 👍🏾