search

jazzband / dj-database-url

Use Database URLs in your Django Application.
https://pypi.org/project/dj-database-url/
BSD 3-Clause "New" or "Revised" License
1.49k stars 205 forks source link

Generic backend registration #171

Open alexanderGerbik opened 2 years ago

alexanderGerbik commented 2 years ago

Add support for custom backend registration with optional config post-processing. Add support for passing arbitrary django database settings as kwargs. Add feature description to README and make README more clear. Extract tests with deprecated options to separate suite to simplify further removal.

mattseymour commented 2 years ago

@alexanderGerbik thanks for the submission, we have had two very similar yet competing PRs come in within a couple of hours of each other. Can I direct you to #170 and see if the changes you made can work along side this PR.

📓 I have put a similar message on #170

dcwatson commented 2 years ago

From what I can tell, this builds off of #151 and changes the options mechanism into a decorator to adjust the parsed settings. Given that it has more tests and an updated README, I'm inclined to start with this PR.

codecov[bot] commented 2 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bcf163e) to head (b27bd63).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #171 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 76 131 +55 Branches 18 33 +15 ========================================= + Hits 76 131 +55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexanderGerbik commented 2 years ago

@mattseymour any chances of this PR being merged? It addresses all the other opened PR's as well as some of opened issues.

mattseymour commented 2 years ago

This is quite a sweeping change. It would be good if we could get a couple of sets of eyes over the ammendments just to make sure we cover off as much as possible. From the outset its looking good. It will just be a case of really giving it a good test.

alexanderGerbik commented 8 months ago

@mattseymour @alanjds Pull request have been updated and doesn't have merge conflicts anymore. I've removed arbitrary Django settings support to increase the chances of this PR to be merged. I'll create another PR for settings support.