search

jazzband / dj-database-url

Use Database URLs in your Django Application.
https://pypi.org/project/dj-database-url/
BSD 3-Clause "New" or "Revised" License
1.48k stars 205 forks source link

Support urlencoding/decoding for hostname #181

Closed Dresdn closed 1 year ago

Dresdn commented 2 years ago

This resolves the conflicts within PR #148, and (I believe) supersedes PR #113. Issue #132 will be closed after nearly 4 years.

Dresdn commented 2 years ago

Paging @mattseymour - this can close out nearly 4 years of open issues and PRs.

codecov[bot] commented 2 years ago

Codecov Report

Merging #181 (fd0b22e) into master (d2e4719) will increase coverage by 2.98%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   86.56%   89.55%   +2.98%     
==========================================
  Files           1        1              
  Lines          67       67              
  Branches       14       14              
==========================================
+ Hits           58       60       +2     
+ Misses          4        3       -1     
+ Partials        5        4       -1
Impacted Files Coverage Δ
dj_database_url.py 89.55% <100.00%> (+2.98%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

palfrey commented 1 year ago

@Dresdn https://github.com/jazzband/dj-database-url/pull/183 appears to have removed EXPECTED_POSTGRES_ENGINE so if you can fix the tests I can get this merged in.

Dresdn commented 1 year ago

@Dresdn #183 appears to have removed EXPECTED_POSTGRES_ENGINE so if you can fix the tests I can get this merged in.

All set @palfrey