search

jazzband / dj-database-url

Use Database URLs in your Django Application.
https://pypi.org/project/dj-database-url/
BSD 3-Clause "New" or "Revised" License
1.48k stars 205 forks source link

Better error on missing schema #196

Closed palfrey closed 1 year ago

palfrey commented 1 year ago

Improves the "missing schema" error, which would improve the situation in https://github.com/jazzband/dj-database-url/issues/186

codecov[bot] commented 1 year ago

Codecov Report

Merging #196 (f55ebcf) into master (1185468) will increase coverage by 0.42%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   89.85%   90.27%   +0.42%     
==========================================
  Files           1        1              
  Lines          69       72       +3     
  Branches       15       17       +2     
==========================================
+ Hits           62       65       +3     
  Misses          3        3              
  Partials        4        4
Impacted Files Coverage Δ
dj_database_url.py 90.27% <100.00%> (+0.42%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rtpg commented 1 year ago

This looks good, but I would leave out the list of supported protocols that are supported. I don't think that's a blocker though.

palfrey commented 1 year ago

This looks good, but I would leave out the list of supported protocols that are supported. I don't think that's a blocker though.

Without that, fixing things like https://github.com/jazzband/dj-database-url/issues/186 would need digging through the source code

rtpg commented 1 year ago

Or, like, the documentation... but I get what you're saying. I don't feel strongly about this!