search

jazzband / dj-database-url

Use Database URLs in your Django Application.
https://pypi.org/project/dj-database-url/
BSD 3-Clause "New" or "Revised" License
1.49k stars 205 forks source link

fix: parse options with numerical values as int #225

Closed estahn closed 1 year ago

estahn commented 1 year ago

fixes #222

codecov[bot] commented 1 year ago

Codecov Report

Merging #225 (5a79985) into master (a7f94c8) will not change coverage. Report is 1 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           69        72    +3     
  Branches        16        16           
=========================================
+ Hits            69        72    +3
Files Changed Coverage Δ
dj_database_url/__init__.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

estahn commented 1 year ago

@mattseymour 👋🏼 Can I get you to have a look at this?

estahn commented 1 year ago

If this can not be generalised we could have an index of options that require conversion to int.

woodsae commented 1 year ago

Amazing, I've been waiting for this fix!

mattseymour commented 1 year ago

Nice one, I am going to start building a v2.1.0 release now.