Proper support for OPTIONS based on DATABASE_URL querystring

jazzband / dj-database-url

Use Database URLs in your Django Application.

https://pypi.org/project/dj-database-url/

BSD 3-Clause "New" or "Revised" License

1.48k stars 205 forks source link

Proper support for OPTIONS based on DATABASE_URL querystring #52

Closed loisaidasam closed 8 years ago

loisaidasam commented 9 years ago

Based on initial work in this pull request, cleaned up, with querystring param parsing split into its own function.

murphyke commented 9 years ago

This PR is important. I also am having to add SSL security to an existing project using dj-database-url.

azreda commented 9 years ago

+1 for supporting OPTIONS, which is needed for SSL and other settings.

edmorley commented 9 years ago

@kennethreitz I don't suppose you've had a chance to look at this? :-)

joshowen commented 9 years ago

kevinwmerritt commented 9 years ago

nwp90 commented 8 years ago

+1. Without this, dj-database-url is unfortunately completely worthless to me.

edmorley commented 8 years ago

For anyone wanting this feature, I'd recommend django-environ, it offers a superset of the dj-database-url functionality and also already supports this.

anentropic commented 8 years ago

@loisaidasam maybe you could squash the commits to make a nice, tidy, appealing PR

kennethreitz commented 8 years ago

:sparkles: :cake: :sparkles: