jazzband / django-admin2

Extendable, adaptable rewrite of django.contrib.admin
BSD 3-Clause "New" or "Revised" License
1.19k stars 151 forks source link

New bootstrap3 default theme + Remove django-crispy-forms and django-floppyforms #434

Closed arthur-wsw closed 8 years ago

arthur-wsw commented 8 years ago

I update the default theme to a bootstrap3 theme.

The new theme is based on sb-admin2. I just write some custom code to hide the sidebar.

The new theme also provide less and sass files

Resolve #360

arthur-wsw commented 8 years ago

I removed the CDN imports and add just the necessary files.

I'm not a fan of CDN too but i also didn't like to have libs directly included in the apps i install.

When deploying a project you could sometime have more than 5 bootstrap/jquery collected when running the manage.py collectstatic and sometimes apps included all the library...

What are you thinking about using a package manager like bower or npm ?

galuszkak commented 8 years ago

@arthur-wsw maybe we should try webpack + npm/bower ? With this we will achieve package management and simple asset minification for production scenarios.

arthur-wsw commented 8 years ago

@galuszkak I'm not familiar with webpack, but it sure is an enhancement.

Maybe we should create an issue, to see if people are interested in and if someone want to contribute?

EDIT: It seems there already have a lot of discussion about using less/sass and that decision was previously made to keep a simple bootstrap theme in default theme #125 To resume it, we should keep it as it is now, as it is more simple for people wanted to contribute on django-admin2 core. However a webpack based theme could be propose as an external app if someone is interested in.

auvipy commented 8 years ago

webpack/systemjs is not that difficult. but as arthur is not experienced with that a issue could be opend

galuszkak commented 8 years ago

@arthur-wsw there is one small additional request 👍 could you add screenshot that will reflect of change to new theme? Thanks in advance :)

arthur-wsw commented 8 years ago

@galuszkak I'm in vacation until Monday, i'll do it as soon as i will be back