Closed smithdc1 closed 3 years ago
Merging #180 (e708d01) into master (8cd75d9) will not change coverage. The diff coverage is
88.95%
.
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 29 29
Lines 1270 1270
=======================================
Hits 1197 1197
Misses 73 73
Impacted Files | Coverage Δ | |
---|---|---|
analytical/templatetags/yandex_metrica.py | 82.35% <61.53%> (ø) |
|
analytical/templatetags/uservoice.py | 80.95% <66.66%> (ø) |
|
analytical/templatetags/mixpanel.py | 90.24% <70.00%> (ø) |
|
analytical/templatetags/kiss_insights.py | 94.11% <80.00%> (ø) |
|
analytical/templatetags/rating_mailru.py | 91.30% <80.00%> (ø) |
|
analytical/templatetags/gauges.py | 91.30% <83.33%> (ø) |
|
analytical/templatetags/google_analytics_gtag.py | 93.10% <83.33%> (ø) |
|
analytical/templatetags/gosquared.py | 91.17% <83.33%> (ø) |
|
analytical/templatetags/optimizely.py | 91.30% <83.33%> (ø) |
|
analytical/templatetags/chartbeat.py | 89.28% <85.71%> (ø) |
|
... and 19 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8cd75d9...e708d01. Read the comment docs.
I see the project has flake8 line length set at 100. I'm not sure how you feel about letting black use this as well?
I'll have a look again through the project and move a few commas about, that may help a little.
I see the project has flake8 line length set at 100. I'm not sure how you feel about letting black use this as well?
Do you intend, instead of the default 88?
I don't know. I think I picked the 100
in the past when I introduced flake8
in this project (I think I did) just to make sure we can activate it hard in Tox/Travis more easily. It's not really an indicator of how strict or not the coding style is. Now that black
is going to rule the project everything's different anyway. Feel free to make whatever choice you deem vital.
We want to make the sort order of imports uniform across all modules, and so do we want to unify the coding style as such.
This is a follow-up of https://github.com/jazzband/django-analytical/pull/152#discussion_r537047137.