jazzband / django-analytical

Analytics services for Django projects
MIT License
1.2k stars 168 forks source link

Implemented isort #187

Closed smithdc1 closed 3 years ago

smithdc1 commented 3 years ago

Breaking these into smaller chunks than the previous attempt -- this one only implements isort. Hopefully, it'll make it easier to review and merge.

Let's see what GitHub Actions has to say about this.

codecov[bot] commented 3 years ago

Codecov Report

Merging #187 (baf1aed) into master (f0e7ebe) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          29       29           
  Lines        1270     1270           
=======================================
  Hits         1197     1197           
  Misses         73       73           
Impacted Files Coverage Δ
analytical/templatetags/google_analytics_js.py 97.77% <ø> (ø)
analytical/templatetags/kiss_insights.py 94.11% <ø> (ø)
analytical/templatetags/olark.py 95.45% <ø> (ø)
analytical/templatetags/analytical.py 97.56% <100.00%> (ø)
analytical/templatetags/chartbeat.py 89.28% <100.00%> (ø)
analytical/templatetags/clickmap.py 91.30% <100.00%> (ø)
analytical/templatetags/clicky.py 93.93% <100.00%> (ø)
analytical/templatetags/crazy_egg.py 93.10% <100.00%> (ø)
analytical/templatetags/facebook_pixel.py 100.00% <100.00%> (ø)
analytical/templatetags/gauges.py 91.30% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0e7ebe...62cc315. Read the comment docs.

bittner commented 3 years ago

Good job, @smithdc1! :1st_place_medal: