PetrDlouhy commented 2 years ago

Add the missing prefix in get_identity() in google_analytics_gtag and test it.

Change of docs and other tests will come in separate PRs.

codecov[bot] commented 2 years ago

Codecov Report

Merging #217 (afef87d) into main (f487cb8) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          31       31           
  Lines        1344     1344           
=======================================
  Hits         1270     1270           
  Misses         74       74

Impacted Files	Coverage Δ
analytical/templatetags/google_analytics_gtag.py	`93.10% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f487cb8...afef87d. Read the comment docs.

PetrDlouhy commented 2 years ago

Hope I fixed all remarks.

PetrDlouhy commented 2 years ago

@bittner I fixed the typos.

bittner commented 2 years ago

@PetrDlouhy Thanks for improving django-analytical! :1st_place_medal:

jazzband / django-analytical

Add the missing get_identity prefix to google_analytics_gtag, test it #217

Codecov Report