Closed remik closed 10 years ago
Any chance to merge it and release to PyPI?
Do you mind updating the travis file to include testing with django 1.6? If we are going to make a change to support it then we should make sure that all the tests pass on 1.6 as well.
Added but jezdez/django-authority
is not connected to travis so won't run automaticly. Should I connect to my fork?
@jezdez do you mind toggling travis on for this repo? I don't have access to that page else I would do it myself.
@remik In the mean time, you can connect your fork and if it passes I'll merge this guy in.
You were right. There is more changes required for Django 1.6. I will handle it. I will also update title for Pull Request.
Awesome, ping me when you are done and we will get this merged into master and pushed to pypi.
@jlward All builds passed as you can see in a row above :)
@remik Thanks for the PR this should be up on pypi in a few minuets.
@remik https://pypi.python.org/pypi/django-authority updated :)
Thanks! This way my old PR https://github.com/jezdez/django-authority/pull/13 also got released finally:)
@jlward Hooked up Travis.
This change breaks (at least) Django 1.3.2 In urls.py, the line
from django.conf.urls import *
doesnt not throw an ImportError as the code expects, but imports the empty init file from that package. Thus, an
NameError : name 'patterns' is not defined
is raised.
In Django 1.6
django.conf.urls.defaults
is removed. This fix updating to new place and keeping compatibility with Django < 1.4setup_environ
is removed. This fix update to use env.