jazzband / django-authority

A Django app that provides generic per-object-permissions for Django's auth app and helpers to create custom permission checks.
http://django-authority.readthedocs.org
BSD 3-Clause "New" or "Revised" License
292 stars 58 forks source link

Support for Django 1.6 #20

Closed remik closed 10 years ago

remik commented 10 years ago

In Django 1.6

remik commented 10 years ago

Any chance to merge it and release to PyPI?

jlward commented 10 years ago

Do you mind updating the travis file to include testing with django 1.6? If we are going to make a change to support it then we should make sure that all the tests pass on 1.6 as well.

remik commented 10 years ago

Added but jezdez/django-authority is not connected to travis so won't run automaticly. Should I connect to my fork?

jlward commented 10 years ago

@jezdez do you mind toggling travis on for this repo? I don't have access to that page else I would do it myself.

jlward commented 10 years ago

@remik In the mean time, you can connect your fork and if it passes I'll merge this guy in.

remik commented 10 years ago

You were right. There is more changes required for Django 1.6. I will handle it. I will also update title for Pull Request.

jlward commented 10 years ago

Awesome, ping me when you are done and we will get this merged into master and pushed to pypi.

remik commented 10 years ago

@jlward All builds passed as you can see in a row above :)

jlward commented 10 years ago

@remik Thanks for the PR this should be up on pypi in a few minuets.

jlward commented 10 years ago

@remik https://pypi.python.org/pypi/django-authority updated :)

remik commented 10 years ago

Thanks! This way my old PR https://github.com/jezdez/django-authority/pull/13 also got released finally:)

jezdez commented 10 years ago

@jlward Hooked up Travis.

laffuste commented 10 years ago

This change breaks (at least) Django 1.3.2 In urls.py, the line

from django.conf.urls import *

doesnt not throw an ImportError as the code expects, but imports the empty init file from that package. Thus, an

NameError : name 'patterns' is not defined 

is raised.