search

jazzband / django-authority

A Django app that provides generic per-object-permissions for Django's auth app and helpers to create custom permission checks.
http://django-authority.readthedocs.org
BSD 3-Clause "New" or "Revised" License
292 stars 57 forks source link

Django 1.7 compatibility #33

Closed DylanLukes closed 8 years ago

DylanLukes commented 10 years ago

Here are some quick and easy fixes that get django-authority running on Django 1.7.

There may be more silent bugs that haven't manifested yet, but this is a good start and doesn't break compatibility with older versions.

Cheers! :wine_glass:

jlward commented 10 years ago

Can you add django 1.7 to the travis config file? If we are going to support it we should be testing it as well.

DylanLukes commented 10 years ago

Hm, just adding 1.7 to the versions isn't going to work since you have to install 1.7 from their repo.

Until it's stable and released it's probably best to avoid adding it to Travis since changes in Django might suddenly cause breakages. Alternatively, the Travis config file is going to need to be restructured somewhat.

Could choose a known stable commit to pull?

jlward commented 10 years ago

I would rather wait to make changes that pertain to 1.7 until 1.7 is released. That way we will be able to add it to travis. I think that is the safest solution here.

entrepreneurj commented 9 years ago

Out of interest, how is this looking now that 1.7 was released?

winhamwr commented 9 years ago

Hello Dylan,

Thanks so much for this PR. As far as things needed for this to be merged in, I think we just need to include a 1.7 environment in tox so that we see the tests run. If you could either do that, or give me access to push to your master branch, I think this might then be ready to roll.

Thanks -Wes