search

jazzband / django-authority

A Django app that provides generic per-object-permissions for Django's auth app and helpers to create custom permission checks.
http://django-authority.readthedocs.org
BSD 3-Clause "New" or "Revised" License
292 stars 57 forks source link

Add support for Django 1.11 #58

Closed jlward closed 6 years ago

jlward commented 6 years ago

It looks like upstream already supports Django 1.11, but some updates needed to be made for tests.

This also fixes a bug with Django 1.8 and permission_required. Basically render_to_string has an order for parameters that we aren't respecting. In your code, it's not actually possible to get into that code path, but we are calling it directly in our code. So I fixed your code to allow getting into that code path again, then fixed the issue (with a test to make sure it doesn't break in the future).

safwanrahman commented 6 years ago

I should say r+

safwanrahman commented 6 years ago

@jlward Is it possible to write a changelog for release note please?

jlward commented 6 years ago

I can add an update note. I have found a bug in testing (looks like it also affects django 1.8). Do you want me to update this PR or make a new one? I have a test with a fix already.

jlward commented 6 years ago

It also seems travis no longer has a python 3.3 interpreter, I would be happy to drop that from the travis config in this PR as well, if you'd like @safwanrahman

safwanrahman commented 6 years ago

@jlward Sure, update it and add it in changelog.

jlward commented 6 years ago

Updated the issue description with a blurb about the follow up issue I fixed. Let me know if there is anything else I can do :)

safwanrahman commented 6 years ago

Merging this as its needed. Sorry for the delay @jlward

jlward commented 6 years ago

Thanks :)