jazzband / django-authority

A Django app that provides generic per-object-permissions for Django's auth app and helpers to create custom permission checks.

http://django-authority.readthedocs.org

BSD 3-Clause "New" or "Revised" License

293 stars 58 forks source link

Add support for Django 2.2 #64

Closed jlward closed 4 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #64 into master will not change coverage. The diff coverage is 14.28%.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   40.71%   40.71%           
=======================================
  Files           8        8           
  Lines         447      447           
  Branches       79       79           
=======================================
  Hits          182      182           
  Misses        258      258           
  Partials        7        7

Impacted Files	Coverage Δ
authority/decorators.py	`41.07% <0%> (ø)`	:arrow_up:
authority/templatetags/permissions.py	`23.56% <16.66%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58e0848...997db47. Read the comment docs.

jlward commented 5 years ago

For reasons that I am unable to explain, the python3 tests on travis do not seem to be creating the test DB. Not really sure what to do about that.

auvipy commented 5 years ago

try to make Travis green

jlward commented 5 years ago

try to make Travis green

I would love to make travis green. However, there seems to be something wonky going on with travis + python3 for this repo. I don't know why, I spent about an hour trying to sort it out. If anyone wants to lend a pair of eyes on it, that would be super. I'm happy to make updates, but I am quickly running out of ideas.

jlward commented 5 years ago

Tests will fail on SQLite if apps without migrations have relations to apps with migrations. This has been a documented restriction since migrations were added in Django 1.7, but it fails more reliably now. You’ll see tests failing with errors like no such table: <app_label>_<model>. This was observed with several third-party apps that had models in tests without migrations. You must add migrations for such models.

This sure looks like what is going on in the python3.7 and django 2.2 tests.

safwanrahman commented 4 years ago

Looks good. r+ Thanks @jlward. Sorry as it took so long!