search

jazzband / django-authority

A Django app that provides generic per-object-permissions for Django's auth app and helpers to create custom permission checks.
http://django-authority.readthedocs.org
BSD 3-Clause "New" or "Revised" License
292 stars 57 forks source link

Fixes ActionErrorList creation resulting in AttributeError #66

Closed mikebq closed 4 years ago

mikebq commented 4 years ago

ActionErrorList is derived from django.forms.utils.ErrorList. Currently ActionErrorList does not call the __init__ method of its base class. The base class requires its __init__ method to be called before extend is called otherwise it results in an AttributeError 'ActionErrorList' object has no attribute 'data'.

I found this while moving a project over to Django 1.11.28 under Python 2.7 and 3.7

codecov[bot] commented 4 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #66   +/-   ##
====================================
  Coverage      39%   39%           
====================================
  Files           7     7           
  Lines         423   423           
  Branches       78    78           
====================================
  Hits          165   165           
  Misses        250   250           
  Partials        8     8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3677b42...94d6f29. Read the comment docs.