Closed supercodepoet closed 11 years ago
btw, all the tests passed in the authority test run
Hi, Thanks for the pull request. Two questions:
Let me know if you have any questions.
So the version of django used for this project is not pegged to a specific version. So what you can do is make your second example app that uses a custom user model and in all the test cases raise SkipTest
if the version of django != 1.5
Travis will automagically only run those tests with django 1.5
I would feel much better merging this in if there was at least one test on the custom user model.
Ok, I will look into adding this in
Ok, as you can see added Travis CI to my fork. I added a custom user model to the example app and activated it only when Django >= 1.5. I updated the tests to use a custom user model test fixture when Django >= 1.5. This way all the tests get run for normal auth.User and now users.User (which contains no username field)
Looks good. Thank you for adding the test.
This uses an internal utility function to grab the proper User class so that it is backwards compatible. We have a current application that uses a custom user model and would love to you django-authority. Please send me any questions, would love to get this merged.