jazzband / django-constance

Dynamic Django settings.
https://django-constance.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.66k stars 307 forks source link

fix migration on mysql #531

Closed sergei-iurchenko closed 8 months ago

sergei-iurchenko commented 8 months ago

https://github.com/jazzband/django-constance/issues/528 Quoted is done correctly now. I have tested on sqlite, mysql & postgresql

codecov[bot] commented 8 months ago

Codecov Report

Merging #531 (1818915) into master (bc9707d) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   90.21%   90.25%   +0.03%     
==========================================
  Files          31       31              
  Lines        1053     1057       +4     
  Branches      156      157       +1     
==========================================
+ Hits          950      954       +4     
  Misses         68       68              
  Partials       35       35              
Files Coverage Δ
...onstance/migrations/0002_migrate_from_old_table.py 86.36% <100.00%> (+3.03%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sergei-iurchenko commented 8 months ago

@camilonova review please