search

jazzband / django-debug-toolbar

A configurable set of panels that display various debug information about the current request/response.
https://django-debug-toolbar.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
7.97k stars 1.03k forks source link

Version 4.4.1 changes the look of DRF browsable API #1922

Closed jeroenbrouwer closed 1 month ago

jeroenbrouwer commented 1 month ago

After upgrading to version 4.4.1 the browsable API suddenly becomes partly dark: image

Whereas on version 4.3 it looks like this: image

matthiask commented 1 month ago

I don't have a project ready with DRF; can you tell which CSS rule does this? Thanks in advance!

matthiask commented 1 month ago

Maybe those lines are the problem: https://github.com/jazzband/django-debug-toolbar/blob/97b49d178b3c2d30cc92ff4fd4f0ecbdcb8bc137/debug_toolbar/static/debug_toolbar/css/toolbar.css#L14 https://github.com/jazzband/django-debug-toolbar/blob/97b49d178b3c2d30cc92ff4fd4f0ecbdcb8bc137/debug_toolbar/static/debug_toolbar/css/toolbar.css#L38

matthiask commented 1 month ago

@jeroenbrouwer It would be great if you could test #1923 !

jeroenbrouwer commented 1 month ago

Disabling this CSS property in Chrome dev-tools fixes it: image

matthiask commented 1 month ago

Thanks. Yes, I thought that this was the case. TBH I was unsure if this property was even needed when merging the PR.

jeroenbrouwer commented 1 month ago

@jeroenbrouwer It would be great if you could test #1923 !

Just tested #1923 and it fixes the issue!

matthiask commented 1 month ago

Thanks for confirming!

jeroenbrouwer commented 1 month ago

Thanks for confirming!

No worries, thanks for the very fast fixing of this issue!