search

jazzband / django-downloadview

Serve files with Django.
https://django-downloadview.readthedocs.io
Other
374 stars 57 forks source link

Add support for Django MIDDLEWARE setting #142

Closed sliverc closed 4 years ago

sliverc commented 6 years ago

Since Django 1.10 middlewares are configured as MIDDLEWARE.

More details: https://docs.djangoproject.com/en/1.11/topics/http/middleware/#upgrading-pre-django-1-10-style-middleware https://docs.djangoproject.com/en/1.11/ref/settings/#std:setting-MIDDLEWARE

This PR adds support to configure django-downloadivew middlewares as MIDDLEWARE. Backwards compatibility with MIDDLEWARE_CLASSES remains.

This fixes #136 For CI to run I included some minor linting fixes.

Natim commented 6 years ago

@sliverc thank you for your work on that.

sliverc commented 6 years ago

@Natim Fixed request changes as mentioned above... is there anything else needing change or can this be merged? Thanks.

jmerkow commented 6 years ago

@sliverc this looks like what I need to fix #143 @Natim is there a reason to delay merge?

Are there any active maintainers on this project anymore?