Closed jmerkow closed 6 years ago
Ok I've solved all the above errors by fixing the middleware except this one:
======================================================================
FAIL: 'storage:static_path' sends not modified response if unmodified.
----------------------------------------------------------------------
demoproject/storage/tests.py", line 50, in test_not_modified_download_response
self.assertTrue(isinstance(response, HttpResponseNotModified))
AssertionError: False is not true```
How was this supposed to work?
I'd like to use this project, but my current software is 2.0. I have been playing around with updating it for django 2.0, which I plan to submit as a PR.
Mostly all good, reverse is in a new place with I've fixed with
except ImportError
catches and a few other minor things.Im having trouble with these 4 tests:
The first three are middleware related. Im not sure why they are failing, the middleware doesn't seem to be engaging at all (possibly an issue with
DOWNLOADVIEW_RULES
.This one I am not sure on... This passes
DownloadMixin.render_to_response() respects HTTP_IF_MODIFIED_SINCE ... ok
but the below does not. I checked the response code is 200, not 304 as you would expect as well.