search

jazzband / django-downloadview

Serve files with Django.
https://django-downloadview.readthedocs.io
Other
384 stars 57 forks source link

Replace mention of deprecated NGINX_DOWNLOAD_MIDDLEWARE_SOURCE_DIR #178

Closed johnthagen closed 3 years ago

johnthagen commented 3 years ago

NGINX_DOWNLOAD_MIDDLEWARE_MEDIA_ROOT is deprecated in favor of NGINX_DOWNLOAD_MIDDLEWARE_SOURCE_DIR

https://github.com/jazzband/django-downloadview/blob/563b2a4f7b354cb930aa7067e6e1341dbb34f5e7/django_downloadview/nginx/middlewares.py#L120-L121

codecov[bot] commented 3 years ago

Codecov Report

Merging #178 (3b94209) into master (563b2a4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files          47       47           
  Lines         608      608           
=======================================
  Hits          521      521           
  Misses         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 563b2a4...9c01be6. Read the comment docs.

johnthagen commented 3 years ago

Pinging @Natim for review.

johnthagen commented 3 years ago

@Natim Friendly ping to see if these doc PRs could be reviewed.