search

jazzband / django-downloadview

Serve files with Django.
https://django-downloadview.readthedocs.io
Other
384 stars 57 forks source link

Add support for Python 3.10 #186

Closed johnthagen closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #186 (f0fca57) into master (0578729) will decrease coverage by 1.96%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   85.69%   83.73%   -1.97%     
==========================================
  Files          47       57      +10     
  Lines         608      965     +357     
==========================================
+ Hits          521      808     +287     
- Misses         87      157      +70
Impacted Files Coverage Δ
django_downloadview/storage.py 100.00% <0.00%> (ø)
django_downloadview/__init__.py 100.00% <0.00%> (ø)
django_downloadview/apache/__init__.py 100.00% <0.00%> (ø)
django_downloadview/lighttpd/__init__.py 100.00% <0.00%> (ø)
django_downloadview/decorators.py 72.72% <0.00%> (ø)
django_downloadview/nginx/__init__.py 100.00% <0.00%> (ø)
django_downloadview/io.py 68.08% <0.00%> (ø)
django_downloadview/api.py 100.00% <0.00%> (ø)
django_downloadview/middlewares.py 78.07% <0.00%> (ø)
django_downloadview/response.py 92.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0578729...f0fca57. Read the comment docs.

johnthagen commented 2 years ago

@Natim @jazzband The pre-commit CI failure seems unrelated to this PR?

johnthagen commented 2 years ago

Looks like we will need to migrate away from nose which is no longer maintained and doesn't support Python 3.10:

Best alternative would be Pytest.

Natim commented 2 years ago

Can you rebase?

johnthagen commented 2 years ago

This PR was superseded by 2524668e865fdaf66089e656ef673de92e2b3656