search

jazzband / django-downloadview

Serve files with Django.
https://django-downloadview.readthedocs.io
Other
364 stars 58 forks source link

Removed passing unused size parameter to was_modified_since(). #194

Closed felixxm closed 1 year ago

felixxm commented 2 years ago

The size parameter is unused because we pass timestamp and not the If-Modified-Since HTML header. Moreover it's outdated and will be removed in Django 4.1, see:

codecov[bot] commented 2 years ago

Codecov Report

Merging #194 (293403b) into master (b64b1ad) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   85.52%   85.51%   -0.02%     
==========================================
  Files          72       72              
  Lines        1313     1312       -1     
==========================================
- Hits         1123     1122       -1     
  Misses        190      190
Impacted Files Coverage Δ
django_downloadview/views/base.py 87.27% <100.00%> (-0.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b64b1ad...293403b. Read the comment docs.