search

jazzband / django-downloadview

Serve files with Django.
https://django-downloadview.readthedocs.io
Other
364 stars 58 forks source link

Improve codebase to python3 #207

Open sevdog opened 9 months ago

sevdog commented 9 months ago

Remove python2 super and drop useless method redefinitions.

Natim commented 9 months ago

Thank you @sevdog

codecov[bot] commented 9 months ago

Codecov Report

Merging #207 (ff5073d) into master (338e171) will increase coverage by 0.03%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   85.51%   85.55%   +0.03%     
==========================================
  Files          72       72              
  Lines        1312     1308       -4     
==========================================
- Hits         1122     1119       -3     
+ Misses        190      189       -1
Files Coverage Δ
demo/demoproject/path/views.py 100.00% <100.00%> (ø)
demo/demoproject/storage/views.py 100.00% <100.00%> (ø)
django_downloadview/apache/middlewares.py 100.00% <100.00%> (ø)
django_downloadview/apache/response.py 100.00% <100.00%> (ø)
django_downloadview/middlewares.py 81.73% <100.00%> (ø)
django_downloadview/response.py 92.59% <100.00%> (+1.02%) :arrow_up:
django_downloadview/test.py 87.93% <100.00%> (ø)
django_downloadview/views/object.py 90.62% <100.00%> (ø)
django_downloadview/views/storage.py 100.00% <ø> (ø)
django_downloadview/files.py 80.67% <50.00%> (ø)
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sevdog commented 9 months ago

I just came across this and was forced to do a couple of updates to better handle my usecase (see https://github.com/sevdog/django-downloadview/tree/updated), I tried to keep single changes to small PRs. If anything else is welcome I will arrange new PRs.