Document how to not trigger a download

quietlyconfident commented 10 years ago

Responsive to Issue #80.

benoitbryon commented 10 years ago

Hi @quietlyconfident, and thanks for the pull-request!

What about the following changes?

move Serving a file inline rather than as a download section from docs/views/object.txt to docs/views/custom.txt, just like the "Handling http not modified responses" section. The attachment option is inherited from DownloadMixin, so it is available for every "*DownloadView" (not only ObjectDownloadView). I think it should be documented along with DownloadMixin.
in docs/views/*.txt (except docs/views/custom.txt) add a link such as "You can also use attributes and methods inherited from DownloadMixin" (feel free to change the wording) which points to docs/views/custom.txt. So that the content you added in "docs/views/object.txt" does not completely disappears from the page: it is replaced by a link, and users who focus on ObjectDownloadView still have the information.
add a test for inline_file_view() in demo/demoproject/object/tests.py
add yourself in AUTHORS ;) Or perhaps https://github.com/benoitbryon/django-downloadview/graphs/contributors is enough?

benoitbryon commented 10 years ago

Hi @quietlyconfident, I updated and merged the pull-request in #83. And just released version 1.6 :) Thanks!

jazzband / django-downloadview