jazzband / django-downloadview

Serve files with Django.
https://django-downloadview.readthedocs.io
Other
380 stars 58 forks source link

Filename with comma won't download in Chrome #87

Closed cjdreiss closed 9 years ago

cjdreiss commented 10 years ago

If a comma is in the file name, Chrome gives an error about multiple headers. The filename parameter needs to be surrounded by double quotes to fix this.

I've fixed it in my fork, and I'm using that code on my app now. I've only tested with ASCII files, I'm going to test a filename that needs to be UTF encoded in a few minutes.

cjdreiss commented 10 years ago

UTF encoding doesn't need the quotes. Fixing that on my fork.