search

jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.
http://django-embed-video.rtfd.org
MIT License
383 stars 135 forks source link

Add GitHub actions CI pipeline #145

Closed aleksihakli closed 3 years ago

aleksihakli commented 3 years ago

Implementation has been copied over from jazzband/django-axes

hramezani commented 3 years ago

Travis CI build status badge in README has to be replaced with Github actions

jezdez commented 3 years ago

In some of the later versions of the release file we've stopped using the pip cache since it was not worth the extra complexity compared the the gains (e.g. GHA cache is invalidated every 2 weeks automatically).

aleksihakli commented 3 years ago

Travis CI build status badge in README has to be replaced with Github actions

I'll check this out as well 👍

In some of the later versions of the release file we've stopped using the pip cache since it was not worth the extra complexity compared the the gains (e.g. GHA cache is invalidated every 2 weeks automatically).

Good note, thanks. I'll deprecate the cache setup from here 👍

aleksihakli commented 3 years ago

Updated the README badge and deprecated pip cache from here and jazzband/django-axes as well.

jezdez commented 3 years ago

Updated the README badge and deprecated pip cache from here and jazzband/django-axes as well.

Sorry, I only meant the release workflow, not the test workflow which is run much more often and where caching actually helps a lot.

aleksihakli commented 3 years ago

Updated the README badge and deprecated pip cache from here and jazzband/django-axes as well.

Sorry, I only meant the release workflow, not the test workflow which is run much more often and where caching actually helps a lot.

Restored the cache in the test phase, disable in releases.

@jezdez Travis CI is reaaaaally slooooow, could it possibly be disabled here in favour of GitHub actions? The project should ported from Travis to GH now.

I'm not certain if it requires the Jazzband PyPI mirror key for correct release functionality on project level?

jezdez commented 3 years ago

Updated the README badge and deprecated pip cache from here and jazzband/django-axes as well.

Sorry, I only meant the release workflow, not the test workflow which is run much more often and where caching actually helps a lot.

Restored the cache in the test phase, disable in releases.

@jezdez Travis CI is reaaaaally slooooow, could it possibly be disabled here in favour of GitHub actions? The project should ported from Travis to GH now.

Done.

I'm not certain if it requires the Jazzband PyPI mirror key for correct release functionality on project level?

Yeah, lemme do this tomorrow when I'm in the office, don't merge this yet.

PS: I've added this PR to the tracking project: https://github.com/orgs/jazzband/projects/1

aleksihakli commented 3 years ago

Updated the README badge and deprecated pip cache from here and jazzband/django-axes as well.

Sorry, I only meant the release workflow, not the test workflow which is run much more often and where caching actually helps a lot.

Restored the cache in the test phase, disable in releases. @jezdez Travis CI is reaaaaally slooooow, could it possibly be disabled here in favour of GitHub actions? The project should ported from Travis to GH now.

Done.

I'm not certain if it requires the Jazzband PyPI mirror key for correct release functionality on project level?

Yeah, lemme do this tomorrow when I'm in the office, don't merge this yet.

PS: I've added this PR to the tracking project: https://github.com/orgs/jazzband/projects/1

It looks like this isn't able to merge either since the Travis job won't trigger anymore and the status check is still required, hehe. If you can merge this later that would be nice.

The master branch is still pending a 1.4.0 release. The changelog and everything else is ready for running a release once the PyPI mirror keys are updated.

jezdez commented 3 years ago

Updated the README badge and deprecated pip cache from here and jazzband/django-axes as well.

Sorry, I only meant the release workflow, not the test workflow which is run much more often and where caching actually helps a lot.

Restored the cache in the test phase, disable in releases. @jezdez Travis CI is reaaaaally slooooow, could it possibly be disabled here in favour of GitHub actions? The project should ported from Travis to GH now.

Done.

I'm not certain if it requires the Jazzband PyPI mirror key for correct release functionality on project level?

Yeah, lemme do this tomorrow when I'm in the office, don't merge this yet. PS: I've added this PR to the tracking project: https://github.com/orgs/jazzband/projects/1

It looks like this isn't able to merge either since the Travis job won't trigger anymore and the status check is still required, hehe. If you can merge this later that would be nice. I've updated the branch protection settings to require the new tests instead.

The master branch is still pending a 1.4.0 release. The changelog and everything else is ready for running a release once the PyPI mirror keys are updated. I've added the Jazzband release key as a secret to the repo.

jezdez commented 3 years ago

Thank you all for working on this ❤️