Use importlib.metadata instead of deprecated pkg_resources

jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.

http://django-embed-video.rtfd.org

MIT License

383 stars 137 forks source link

Use importlib.metadata instead of deprecated pkg_resources #200

Closed q0w closed 10 months ago

q0w commented 11 months ago

I am not sure if this package still supports python<3.8 (no constraints in python_requires)

aleksihakli commented 10 months ago

Hey! Thanks for the update. The Python 3.7 and Django 4.0 versions will be dropped from the support matrix as Python 3.7 is EOL as of 2023-06-27, but the CI test matrix configuration still requires them to pass. Seems like the PR needs some work to be mergeable.

q0w commented 10 months ago

@aleksihakli I added importlib-metadata backport for python3.7. Could you please run ci for this pr?

aleksihakli commented 10 months ago

Hey, this should now be fixed, I was able to run the CI pipeline in #201 after repushing your commit, it should show up under your name correctly on the commit log & GitHub :)