search

jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.
http://django-embed-video.rtfd.org
MIT License
383 stars 137 forks source link

Add Django 5.0 and Python 3.12 to test matrix #204

Closed mgrdcm closed 1 month ago

mgrdcm commented 1 month ago

The fix in https://github.com/jazzband/django-embed-video/pull/201 is required for Python 3.12 so wanted to add testing to cover that, and adding Django 5.0 support at the same time.

Should probably remove support for unsupported Django and Python versions, but that might require a breaking change version bump. Hoping we can get a release out soon that has the https://github.com/jazzband/django-embed-video/pull/201 change in it, and then remove support?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.65%. Comparing base (a15a446) to head (a436b2e).

:exclamation: Current head a436b2e differs from pull request most recent head 96bae53. Consider uploading reports for the commit 96bae53 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #204 +/- ## ========================================== - Coverage 98.95% 98.65% -0.30% ========================================== Files 16 16 Lines 671 671 Branches 67 66 -1 ========================================== - Hits 664 662 -2 - Misses 4 5 +1 - Partials 3 4 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aleksihakli commented 1 month ago

Yeah, let's bake a release after this is merged 👍

mgrdcm commented 1 month ago

Yeah, let's bake a release after this is merged 👍

Awesome! Fixed the one thing you mentioned. I suppose I could merge it but probably best you do since it's my PR :)

I'm also not familiar with how to get a release of this out, are there instructions? Or if you're able to just do it, that works too and thank you!