search

jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.
http://django-embed-video.rtfd.org
MIT License
383 stars 135 forks source link

Change requests.get kwarg from data to params when calling SoundCloud AP... #28

Closed rolo closed 10 years ago

rolo commented 10 years ago

This was failing for me with an error 400 error, and the requests docs (http://docs.python-requests.org/en/latest/user/quickstart/#passing-parameters-in-urls) say to use a kwarg called params rather than data. I've changed this and it now works. Not sure if this is something which has changed in the requests lib.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 1133071ed1a710c3740fc8a996996aff91792719 on rolo:patch-1 into bccaec0d8bdd31512853c9f4dc52ac27d3fc2727 on yetty:master.

yetty commented 10 years ago

Thanks.