jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.
http://django-embed-video.rtfd.org
MIT License
382 stars 135 forks source link

Soundcloud embed fails? #29

Closed mpachas closed 10 years ago

mpachas commented 10 years ago

I'm not sure about this, but maybe Soundcloud has done some changes on its API, but embeds are not working now in my project, could you please check this? Got this when testing: ERROR: test_code (embed_video.tests.tests_backend.SoundCloudBackendTestCase) FAIL: test_get_thumbnail_url (embed_video.tests.tests_backend.VimeoBackendTestCase)

Thanks in advance.

yetty commented 10 years ago

What version of django-embed-video are you using?

mpachas commented 10 years ago

Sorry, tests run Ok in your project, that errors are my fault. But using this in my project is still not working. I get

Exception: Uncaught TypeError: Cannot read property 'fetch' of undefined widget-64e4a217.js:3 s.constructor {resource_id: "f-2", attributes: Object, _escapedAttributes: Object, cid: "c12", _setting: false…} widget-64e4a217.js:3 Uncaught TypeError: Cannot read property 'fetch' of undefined single-sound-bf7b729e.js:10

in Chrome console, and

"Exception: TypeError: a is undefined" widget-64e4a217.js:3 Object { resource_id: "f-2", attributes: Object, _escapedAttributes: Object, cid: "c12", _setting: false, _previousAttributes: Object, id: "c12", fatal: false, _submodels: Array[0], _changed: Object } widget-64e4a217.js:3 TypeError: a is undefined single-sound-bf7b729e.js:10

in firefox.

and it renders like this captura de pantalla 2014-07-03 a la s 11 01 18

I'll keep working on this, but it could be helpful if you can check if Soundcloud embed's are working for you. Thanks.

yetty commented 10 years ago

It's working fine for me. If you try to run example project [1], there are items from SoundCloud ("Lost in the echo" for example).

Please send more details about your implementation and url of soundcloud you are trying to embed.

[1] http://django-embed-video.readthedocs.org/en/v0.10/example-project.html

mpachas commented 10 years ago

It's fine in your project. I'll keep working on testing my implementation, if I discover smtg buggy I'll tell you, thanks.

mpachas commented 10 years ago

I think the problem is that we were using embed templatetag and it does not work now in Soundcloud (maybe because this: tag but always uses insecure HTTP protocol. ) But well, it's deprecated so I'll try to use the embed function.