Get better resolutions from youtube with fallback for default resolution

[DiogoMarques29]

43

[DiogoMarques29]

Hi, can you help with these errors?

[yetty]

Please cover your changes with unit tests. Read more at the docs. I'll write some suggestions directly to the code.

Errors are caused by not supporting of Django 1.9. You can take a look at it, but if you don't, I will do it soon.

[DiogoMarques29]

@yetty hi, I will fix the code asap. I'm trying to resolve compatibility with django 1.9.1 and i got stuck in the last test, about south. In fields.py line 23 we got from south.modelsinspector import introspector witch is no longer supported by django. got any ideias? (I will write some testes now to cover my enchantments.)

[DiogoMarques29]

I love this continuous-integration of travis-ci !!! I will start to use it on my projects! ;)

Now there is only the error i told you about, south. Can you take a look at it?

[DiogoMarques29]

Hi @yetty Can i remove def south_field_triple(self): function form EmbedVideoField? that's what causing the tests to fail because south is not ready for django 1.9. I'm wondering if this is used as a backwards compatibility for projects with south.

[yetty]

Please don't remove it, but make it dependable on Django version. Use something like this:

from django.utils import version

...

if version.get_version() < 1.9:
    def south_field_triple(self):

It will keep it backward compatible.

[DiogoMarques29]

According to the docs https://docs.djangoproject.com/en/1.9/releases/1.9/#python-compatibility django 1.9 is not compatible with python 3.3, so i will change python from 3.3 to 3.4 in travis file.

[yetty]

Ok, thanks.