search

jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.
http://django-embed-video.rtfd.org
MIT License
382 stars 135 forks source link

Improvements to URL's and Tests #6

Closed techdragon closed 11 years ago

techdragon commented 11 years ago

The vimeo and youtube urls are now able to handle a few more formats as defined in the tests.

The regex is able to handle a few more formats than the ones covered in the tests, I'm unwilling to add arbitrary test cases till i can find some proper documentation to back up the format. I'm currently looking for a better regex that requires less use of specific match patterns to catch all the various formats. But this one blocks the fake urls you pointed out, and catches all the formats i can think of or have found suggested. I also added more test cases to match the improvements, and fixed a faulty test that didnt use a proper input format to test with.

yetty commented 11 years ago

Great! Thank you.

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling 085b65024a4f71fe578d62ef693417927c445edc on techdragon:master into b8611cdd504018151c472f360a5797bb58a0cb53 on yetty:master.