Closed bmoe872 closed 7 years ago
@mgrdcm - Let me know if you need anything else, or the code needs to be changed
Cheers!
/cc @thijstriemstra @yetty
Please, review the travis
test problems.
@SalahAdDin every time I click details for travis-ci i get a page that says The repository at yetty/django-embed-video was not found.
From what I recall though, running nosetests
as the documentation requests for testing, I was getting errors on the Soundcloud portion of code.
@bmoe872 it's been moved to jazzband/django-embed-video today and maybe travis hasn't been enabled there yet? See #65 for PR that fixes the badge in README.
@thijstriemstra and @SalahAdDin looking at the travis test problems, the errors lie within the soundcloud portion. (Which I did not touch), and looking at your past PR's it looks like its been an ongoing issue.
Any idea for solve this issue?
Well, since the package is called "django-embed-video" Im not entirely sure it makes sense to have soundcloud included anyways? Since soundcloud is purely audio.
@bmoe872 Right man, you're right, so, have to delete these sound cloud "support".
What Is this?
https://wistia.com/ provides a video service similar to that of youtube, or vimeo. The added benefit being analytics, and a full set of features to customize the look of the video, and how it behaves.
Why add this?
Wistia is becoming a popular go-to for businesses that want to have video's embedded on their site. This Link: https://wistia.com/blog/wistia-vs-youtube provides a pretty good run-down of why businesses would choose wistia over youtube.
How to test?
Simply run the nose tests supplied, and to test usability simply use the example project provided, and upload one of the available wistia video urls in place of a vimeo or youtube video. Public wistia videos are difficult to find, but I have provided two links in the test_wistia_video_embed file.