search

jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.
http://django-embed-video.rtfd.org
MIT License
383 stars 137 forks source link

Enable default HTTPS support #86

Closed marcosguedes closed 5 years ago

marcosguedes commented 6 years ago

All supplied backends support HTTPS. I think it's fine to support HTTPS by default

joelschopp commented 6 years ago

Agree, we should switch to https being default

cedriccarrard commented 5 years ago

@marcosguedes Please look to correct the tests thanks

marcosguedes commented 5 years ago

@CedricCarrard thanks for pointing that out, I'll handle it asap

marcosguedes commented 5 years ago

@CedricCarrard Fixed. Apologies for the wait, I've never used tests like these before, I've learned a lot :)

marcosguedes commented 5 years ago

Oof! I've deleted some urls from https://github.com/jazzband/django-embed-video/pull/86/files#diff-f92ad249831b527c54fad3b729d24754 I shouldn't have. Fixing...

marcosguedes commented 5 years ago

How odd... it retrieved a vimeo thumbnail on http after requesting https on Django==1.10.x . I've tested it 5 times and it was a success everytime. Is this a vimeo issue?

mgrdcm commented 5 years ago

Hey!

Even if secure/SSL is the default, not sure we'd want to remove any of the tests for http URLs, since those are still valid too.

cedriccarrard commented 5 years ago

@mgrdcm Would you have time to help @marcosguedes finish the pull-request? I'm waiting on the pull request to create a new version.

mgrdcm commented 5 years ago

I can, but might be a day or two...

marcosguedes commented 5 years ago

Hi @CedricCarrard @mgrdcm so sorry, heavy workload these past days and I completely forgot. Will try again today in about 5h.

Cheers and thank you for your patience!

marcosguedes commented 5 years ago

Hi there @mgrdcm , @CedricCarrard ! Apologies for being late. Is it ok right now? Not sure if I git-reverted successfully

mgrdcm commented 5 years ago

@CedricCarrard I can merge this if you prefer, otherwise leaving it for you to make final call. Thanks!

cedriccarrard commented 5 years ago

@mgrdcm @marcosguedes good work guys thanks.