search

jazzband / django-fernet-encrypted-fields

MIT License
47 stars 10 forks source link

Adding typings to codebase #16

Open faradayyg opened 1 year ago

faradayyg commented 1 year ago

I am using this issue as a discussion board sort of.

Since the change in #15 updated the required python version to 3.8 and updated the minimum Django version to 3.2, I would like to add typings to the entire codebase.

As we all know, there are many advantages to typing, most importantly is that it eliminates an entire class of errors.

Let me know if anyone has objections to this. Else, I'd like to get started on this.

As a follow up, we could add some type checkers such as Mypy to the codebase. I of course would be willing to do this as well.

frgmt commented 1 year ago

@faradayyg Thank you. I don't think anyone would disagree. I'd like to appreciate you for working on it.

faradayyg commented 1 year ago

Cool! Keeping this issue open as a kind of TODO Item. Will close as soon as I have a PR that is accepted.

Thanks for your quick responses @frgmt

kevalrajpalknight commented 10 months ago

Hi @faradayyg

I hope you're doing well! 👋 I noticed that the typing issue #15 has been open for about 6 months now, and I'm eager to contribute to the project. I see that adding typings and type checkers like Mypy would be beneficial for the codebase.

If you haven't had the chance to start working on this, I'd be happy to take it up. Let me know if it's okay with you, and I'll get started on preparing a PR. If there's anything specific you'd like me to focus on or if you have any guidance, please feel free to share.

Looking forward to contributing to the project!

faradayyg commented 10 months ago

Hello @kevalrajpalknight I kind of got stuck at some point and got busy with other things, I'd be glad if you could take this on, and will be available to provide all the support you need.

I have not really done anything on this yet, so you can start afresh with this.

Many thanks and looking forward to collaborating on this.

kevalrajpalknight commented 10 months ago

Alright, thanks for the update @faradayyg I will start working on this, I will be happy if we can work on this together. That would help to achieve the goal more quickly.