Update ci and code - Githubissues

jazzband / django-fernet-encrypted-fields

MIT License

42 stars 9 forks source link

Open sevdog opened 3 months ago

sevdog commented 3 months ago

This PR performs some updates:

Update CI to work on github actions rather than travis.ci
Add django 5.0 and python 3.11/3.12, remove python 3.7 from CI
Update codebase to better use python 3.8 features
Remove raw SQL formatting in tests (which is a bad practice)
Refactor encryption to reduce code redundancy in JSONField
Refactor validators definition for IntegerField to avoid copypasting code from django and to address connection specific limits

artursmet commented 3 months ago

Hi,

Looks like we have introduced almost the same changes regarding the CI setup 😅 https://github.com/jazzband/django-fernet-encrypted-fields/pull/19 Since your changeset covers a lot more, I'm happy to close my PR and wait for your changes to be merged.

frgmt commented 3 months ago

@sevdog @artursmet Thank you both!

sevdog commented 2 months ago

Seems that I forgot to explicity setup the codecov token for upload, the solution would be to add the that step (as pointed here)

      env:
        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Which is the name of the secret in which codecov token is stored?

frgmt commented 2 months ago

@sevdog I'm not code owner now and I can't change settings. So I don't really know if I can set up token.. 🙏 Should we ask the jazzband maintainers?