Closed victorouttes closed 2 years ago
StevenMapes
commented
2 years ago What format is your token? The InvalidToken is not being raise by this package but it being raised by the main pyca cryptography package - https://github.com/pyca/cryptography/blob/main/src/cryptography/fernet.py
If you look at that package the line raising the validation is this
if not data or data[0] != 0x80:
raise InvalidToken
victorouttes
commented
2 years ago When I submit a form in Django Admin, it calls default "clean()" function which is:
def clean(self, value, model_instance):
"""
Convert the value's type and run validation. Validation errors
from to_python() and validate() are propagated. Return the correct
value if no error is raised.
"""
value = self.to_python(value)
self.validate(value, model_instance)
self.run_validators(value)
return valueThe problem is in self.to_python(value). Variable value is the input from form (can be any text by app user).
This call self.to_python(value) is going to encrypted_fields/fields.py:
def to_python(self, value):
if value is None or not isinstance(value, str):
return value
value = self.f.decrypt(bytes(value, 'utf-8')).decode('utf-8')
return super(EncryptedFieldMixin, self).to_python(value)raising error in value = self.f.decrypt(bytes(value, 'utf-8')).decode('utf-8').
So, any Django Admin form input (like "Hello World!") is going to be decrypted in self.f.decrypt(bytes('Hello World!', 'utf-8')). That's the error cause, because decrypt is expecting an encrypted string.
The encrypted_fields to_python(self, value) may be overriding Django's (from django.db.models.fields) to_python(self, value)? Any tip on this?
Thanks in advance.
StevenMapes
commented
2 years ago Here's how I've added a work around for my project
def _get_validation_exclusions(self):
"""Overload this method to add the encrypted fields to the list of exclusions used by full_clean"""
exclude = super()._get_validation_exclusions()
for field in self.fields:
if isinstance(getattr(self._meta.model, field).field, EncryptedFieldMixin):
exclude.append(field)
return excludeThis will add any Encrypted fields on the model that you are using into the exclusion list created by the _post_clean method which then calls the full_clean method on the instance.
You can still add custom validation to the clean_* methods on the form to validate and raise any errors.
I need to check but it may be possible to move this into the EncryptedFieldMixin class against it's full_clean method as well but I have not tested that far down yet.
Here's an example where my model UserProfile has two encrypted fields
admin.py
class UserProfileInline(admin.StackedInline):
model = UserProfile
form = UserProfileAdminFormforms.py
from encrypted_fields.fields import EncryptedFieldMixin
class UserProfileAdminForm(ModelForm):
class Meta:
model = UserProfile
def _get_validation_exclusions(self):
"""Overload this method to add the encrypted fields to the list of exclusions used by full_clean"""
exclude = super()._get_validation_exclusions()
for field in self.fields:
if isinstance(getattr(self._meta.model, field).field, EncryptedFieldMixin):
exclude.append(field)
return excludeOkay I tested the model level and this can be fixed by overloading the clean method at the base model field level by simply running the actions of django.db.models.fields.init.clean without calling the to_python
def clean(self, value, model_instance):
"""
Convert the value's type and run validation. Validation errors
from to_python() and validate() are propagated. Return the correct
value if no error is raised.
"""
self.validate(value, model_instance)
self.run_validators(value)
return valueHowever a better method, IMO, would be to use a temporary instance property which we create within the clean method, then call the super, then remove it from the instance. This means the to_python method can be updated to check for that property and, if it exists, can skip decryption. It's more code but means it's less likely to break with future changes to Django's field's clean method as we know it will run as it's suppose to.
def to_python(self, value):
if value is None or not isinstance(value, str) or hasattr(self, '_already_decrypted'):
return value
value = self.f.decrypt(bytes(value, 'utf-8')).decode('utf-8')
return super(EncryptedFieldMixin, self).to_python(value)
def clean(self, value, model_instance):
"""
Convert the value's type and run validation. Validation errors
from to_python() and validate() are propagated. Return the correct
value if no error is raised.
"""
self._already_decrypted = True
ret = super().clean(value, model_instance)
del self._already_decrypted
return retI'll fork and create a new PR based on the latter
I'm getting this error when saving data using django admin:
Model:
Admin:
Django version: 4.0 Database: sqlite