search

jazzband / django-floppyforms

Full control of form rendering in the templates.
http://django-floppyforms.readthedocs.org/
Other
839 stars 145 forks source link

DecimalField now uses min, max, and decimal places (step) to create numberinput widget #150

Closed caacree closed 9 years ago

caacree commented 9 years ago

See issue #70. Just used the same code as integerfield for min and max, with the addition of attrs['step']=1/(10^self.decimal_places). Similarly, added tests to verify it works.

gregmuellegger commented 9 years ago

Awesome! Thanks for your work on this. Also big plus that you include some tests. Unfortunatelly the tests fails currently on Travis. Can you have a look at this? See https://travis-ci.org/gregmuellegger/django-floppyforms/jobs/63480775#L477

gregmuellegger commented 9 years ago

Hi you can see the test results of your commits right in this pull request: screen

The red crosses on the right show you that the tests have failed. Click on them to open up TravisCI and see what went wrong. You don't need to install anything as TravisCI is a website.

You can also run the test suite locally on your computer by following these instructions: https://github.com/gregmuellegger/django-floppyforms#development

That way you don't need to commit and push any changes before seeing the results of the tests.

Happy coding! :)

caacree commented 9 years ago

Finally! Those whitespace errors we're killing me; not sure why it does that. Never would've thought it mattered whether empty lines had whitespace characters or not in python.

Anyways, tests all pass if you're good to go.

gregmuellegger commented 9 years ago

Great! Thanks for all the work, I merged your work (see c09f7ca and b91d014494741b80bf1572a3529a5525bf9c7785), however I adjusted the commit message to be more descriptive than Update fields.py, that's why this PR is not listed as merged.

:+1: Good work! This will be part of the 1.5 release. However I cannot tell yet when this will be released.