jazzband / django-floppyforms

Full control of form rendering in the templates.
http://django-floppyforms.readthedocs.org/
Other
839 stars 145 forks source link

5 tests fail with Django 1.6 #90

Closed fladi closed 10 years ago

fladi commented 10 years ago

Running the tests with Django 1.6 causes several tests to fail.

======================================================================
FAIL: test_field_config_for_bound_field (floppyforms.tests.templatetags.FormConfigNodeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/buildd/django-floppyforms-1.1/floppyforms/tests/templatetags.py", line 191, in test_field_config_for_bound_field
    'floppyforms/input.html')
AssertionError: None != 'floppyforms/input.html'

======================================================================
FAIL: test_field_config_for_field_name (floppyforms.tests.templatetags.FormConfigNodeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/buildd/django-floppyforms-1.1/floppyforms/tests/templatetags.py", line 208, in test_field_config_for_field_name
    'floppyforms/input.html')
AssertionError: None != 'floppyforms/input.html'

======================================================================
FAIL: test_pass_values (floppyforms.tests.fields.IntegerFieldTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/buildd/django-floppyforms-1.1/floppyforms/tests/fields.py", line 32, in test_pass_values
    </p>""")
File "/usr/lib/python2.7/dist-packages/django/test/testcases.py", line 652, in assertHTMLEqual
    self.fail(self._formatMessage(msg, standardMsg))
AssertionError: <p>
<label for="id_num">
Num:
</label><input id="id_num" max="10" name="num" typ [truncated]... != <p>
<label for="id_num">
Num:
</label><input id="id_num" max="10" name="num" req [truncated]...
Diff is 758 characters long. Set self.maxDiff to None to see it.

======================================================================
FAIL: test_number (floppyforms.tests.widgets.WidgetRenderingTest)
<input type="number">
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/buildd/django-floppyforms-1.1/floppyforms/tests/widgets.py", line 320, in test_number
    """)
File "/usr/lib/python2.7/dist-packages/django/test/testcases.py", line 652, in assertHTMLEqual
    self.fail(self._formatMessage(msg, standardMsg))
AssertionError: <p>
<label for="id_num">
Num:
</label><input id="id_num" name="num" step="any" t [truncated]... != <p>
<label for="id_num">
Num:
</label><input id="id_num" name="num" required typ [truncated]...
<p>
<label for="id_num">
Num:
- </label><input id="id_num" name="num" step="any" type="number" />
?                                       ^^ ^^^^^^^

+ </label><input id="id_num" name="num" required type="number" />
?                                       ^ ^^^^^^

</p>

======================================================================
FAIL: test_number (floppyforms.tests.widgets.WidgetRenderingTestWithTemplateStringIfInvalidSet)
<input type="number">
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/buildd/django-floppyforms-1.1/floppyforms/tests/widgets.py", line 320, in test_number
    """)
File "/usr/lib/python2.7/dist-packages/django/test/testcases.py", line 652, in assertHTMLEqual
    self.fail(self._formatMessage(msg, standardMsg))
AssertionError: <p>
<label for="id_num">
Num:
</label><input id="id_num" name="num" step="any" t [truncated]... != <p>
<label for="id_num">
Num:
</label><input id="id_num" name="num" required typ [truncated]...
<p>
<label for="id_num">
Num:
- </label><input id="id_num" name="num" step="any" type="number" />
?                                       ^^ ^^^^^^^

+ </label><input id="id_num" name="num" required type="number" />
?                                       ^ ^^^^^^

</p>
gregmuellegger commented 10 years ago

I think those issues are fixed in the current master. I have just added Travis builds for Django 1.6 and they run fine. Can you please try again with the master and or specify with what revesion of floppyforms have you tested?

fladi commented 10 years ago

I did my tests with the 1.1 release (building it for Debian). I will give it a try with current master.

carljm commented 10 years ago

Confirmed (via tox) that all tests (including 1.6 tests) are passing on master. I think this issue should be closed.

gregmuellegger commented 10 years ago

Thanks @carljm for confirming it. I'll close this issue then.