search

jazzband / django-formtools

A set of high-level abstractions for Django forms
https://django-formtools.readthedocs.io
BSD 3-Clause "New" or "Revised" License
794 stars 135 forks source link

Elevate warnings to errors and fix deprecation warnings #179

Closed smithdc1 closed 3 years ago

smithdc1 commented 3 years ago

I was surprised I didn't see any warnings when running the test suite earlier.

This pull request turns all warnings into errors so we can see them sooner. To help with this I've also then allowed failures against Django master in Travis.

Seems to work locally, I'll keep my fingers crossed for Travis.

smithdc1 commented 3 years ago

@claudep I'm wondering if you could point me in the right direction here as I think this is close....

What I really want to do is run the tests via django-admin and change warnings into errors. Usually, I'd see something like Python -W error::...... But I don't seem to be able to get that to work here.

What am I missing?

claudep commented 3 years ago

I cannot tell you what to do, maybe let things as they are now (and do the -Werr locally to fix warnings).

Please submit a separate PR for the url to path conversion.

smithdc1 commented 3 years ago

Ok, Will do. Thanks.