jazzband / django-formtools

A set of high-level abstractions for Django forms
https://django-formtools.readthedocs.io
BSD 3-Clause "New" or "Revised" License
794 stars 135 forks source link

Added support for Django 3.2 #193

Closed hramezani closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #193 (9b1594b) into master (1d36dd6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          11       11           
  Lines         527      527           
  Branches       66       66           
=======================================
  Hits          492      492           
  Misses         22       22           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 1d36dd6...9b1594b. Read the comment docs.

hramezani commented 3 years ago

LGTM, maybe we should get rid of py3.5 as well?

Maybe we need to keep Py3.5 support for Django2.2

jezdez commented 3 years ago

Problem is that Python 3.5 is EOL already and doesn't even receive security fixes anymore. It's not sensible to support Python versions that have stopped being supported from upstream.

carltongibson commented 3 years ago

@jezdez People have shouted at me for saying that. πŸ˜€ (I agree but...)

hramezani commented 3 years ago

Ok, I will create a patch to remove support for python 3.5

jezdez commented 3 years ago

@jezdez People have shouted at me for saying that. πŸ˜€ (I agree but...)

I feel for you being shouted at, I've been there.

claudep commented 3 years ago

It's nothing serious enough to shout at anyone, but you also have to understand that some people are looking for long-term stability (going even to the extra effort of backporting security to no-longer-supported releases), and I think both parties should respect one another, WITHOUT SHOUTING :-)

jezdez commented 3 years ago

It's nothing serious enough to shout at anyone, but you also have to understand that some people are looking for long-term stability (going even to the extra effort of backporting security to no-longer-supported releases), and I think both parties should respect one another, WITHOUT SHOUTING :-)

True, you've probably seen many of those discussions over the years, so I'm happy you're chiming in! No shouting needed :)

There is sadly no way to handle custom long-term support requests for Jazzband projects other than on the individual member level at the moment. If in doubt, please feel free to reach out to me (or the project leads) if there is interest in working something out.