jazzband / django-fsm-log

Automatic logging for Django FSM
https://django-fsm-log.readthedocs.io/en/latest/
MIT License
242 stars 79 forks source link

:tractor: Migrate to django-fsm-2 #188

Open jefftriplett opened 6 months ago

jefftriplett commented 6 months ago

I recently switched to https://pypi.org/project/django-fsm-2/, and dropping the django_fsm setup requirement would still allow other spiritual successor projects to work. https://github.com/jazzband/django-fsm-log/blob/master/setup.py#L22

I'm happy to create a new issue and submit a PR if this is helpful?

lorenzomorandini commented 5 months ago

Fine for me, since django-fsm (1) won't be updated anymore I don't see a reason to keep it as dependency. Still we should consider to document this, especially if django-fsm-2 will ever introduce breaking changes with django-fsm.

pfouque commented 5 months ago

especially if django-fsm-2 will ever introduce breaking changes with django-fsm.

That's not the plan! ;) The main idea is to keep publishing releases according to Python & Django version upgrades. I may add type hints at some point, but feature-wise, the scope is complete IMO!