jazzband / django-fsm-log

Automatic logging for Django FSM
https://django-fsm-log.readthedocs.io/en/latest/
MIT License
241 stars 78 forks source link

StateLog.description: use null=True #84

Closed blueyed closed 6 years ago

blueyed commented 6 years ago

This is crucial for migrations, e.g. PostgreSQL < 11.

Fixes https://github.com/gizmag/django-fsm-log/issues/83.

codecov-io commented 6 years ago

Codecov Report

Merging #84 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #84      +/-   ##
=========================================
+ Coverage   96.17%   96.2%   +0.03%     
=========================================
  Files          22      23       +1     
  Lines         470     474       +4     
=========================================
+ Hits          452     456       +4     
  Misses         18      18
Impacted Files Coverage Δ
...go_fsm_log/migrations/0003_statelog_description.py 100% <ø> (ø) :arrow_up:
django_fsm_log/models.py 100% <100%> (ø) :arrow_up:
tests/test_model.py 100% <100%> (ø) :arrow_up:
django_fsm_log/migrations/0005_description_null.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 263fc93...ba787f6. Read the comment docs.

blueyed commented 6 years ago

Thanks! We should have a new release with this. Will you do it again?

ticosax commented 6 years ago

yes i can.