search

jazzband / django-hosts

Dynamic and static host resolving for Django. Maps hostnames to URLconfs.
http://django-hosts.rtfd.org
Other
982 stars 106 forks source link

Fix Travis deployment condition #115

Closed timgraham closed 4 years ago

timgraham commented 4 years ago

Broken in 2e6e526f3a84c1f8c867f41c0537f4d8c949cf48

(untested, may not work)

timgraham commented 4 years ago

@Djailla, does it look like it might work?

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0a97a812a07da0afc2671308ae1c56a741facace on deployment-condition into cd11ce7aa5553facbe3751a51d0e48c315aff599 on master.

Djailla commented 4 years ago

Looks good to me !

jezdez commented 4 years ago

Hey folks sorry for the breakage, it would be better to just use build stages for this so no condition is needed. I'll update the branch with the needed change..

jezdez commented 4 years ago

@timgraham Let me know if this doesn't works out when you redo the 4.0 tag. Thank you!