Closed x-yzt closed 3 years ago
Merging #121 (2482a28) into master (f0b8099) will decrease coverage by
0.24%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## master #121 +/- ##
===========================================
- Coverage 100.00% 99.75% -0.25%
===========================================
Files 10 11 +1
Lines 395 401 +6
Branches 59 60 +1
===========================================
+ Hits 395 400 +5
- Partials 0 1 +1
Impacted Files | Coverage Δ | |
---|---|---|
django_hosts/middleware.py | 97.87% <80.00%> (-2.13%) |
:arrow_down: |
django_hosts/__init__.py | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f0b8099...2482a28. Read the comment docs.
Assuming this configuration:
settings.py
hosts.py
This PR will allow, as expected,
exemple.test/...
to be catched by theroot
pattern, andother.exemple.test/...
by theother
pattern.Currently, the
exemple
part ofexemple.test
is stripped out, andhost(r'', ...)
never matches. This is kind of confusing, because on a dev server where the host islocalhost
, everything works as expected.I must admit my solution is not pretty though.